-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x: Fix mergeWith not cancelling the other source if the main errors #6598
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.x #6598 +/- ##
===========================================
- Coverage 98.22% 98.2% -0.03%
+ Complexity 6185 6184 -1
===========================================
Files 678 678
Lines 44908 44908
Branches 6214 6214
===========================================
- Hits 44111 44100 -11
- Misses 266 272 +6
- Partials 531 536 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo in some of the test method names. The rest of the fix looks great.
The
mergeWith
implementations'onError
(called by the main source) cancelled the main source instead of cancelling the other source. This mistake affects all 2 x 3 overloads of the operator.Fixes #6597