-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a base test class and have all unit tests extend it #6589
Create a base test class and have all unit tests extend it #6589
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.x #6589 +/- ##
============================================
+ Coverage 98.16% 98.21% +0.05%
- Complexity 6183 6187 +4
============================================
Files 678 678
Lines 44908 44908
Branches 6214 6214
============================================
+ Hits 44083 44107 +24
+ Misses 278 268 -10
+ Partials 547 533 -14
Continue to review full report at Codecov.
|
7b1fc00
to
4eb011f
Compare
Thanks for updating the description and the review. I amended the commit to meet the new PR description. |
This commit creates the `RxJavaTest` class defining a default timeout to 5 minutes. An ignored test announce itself for each running class extending it preventing Travis CI from killing the build. Have `Completable` tests extend from `RxJavaTest`. Have `Disposable` tests extend from `RxJavaTest`. Have `Exception` tests extend from `RxJavaTest` Related: ReactiveX#6583
4eb011f
to
477394e
Compare
@RomanWuattier do you want to do the rest of the test classes in a separate PR? |
@akarnokd yes, you can merge this one when you want to. |
Thanks! |
This commit creates the
RxJavaTest
class defining a defaulttimeout to 5 minutes. An ignored test announce itself for each
running class extending it preventing Travis CI from killing the
build.
Have
Completable
tests extend fromRxJavaTest
.Have
Disposable
tests extend fromRxJavaTest
.Have
Exception
tests extend fromRxJavaTest
Related: #6583