Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a base test class and have all unit tests extend it #6589

Merged

Conversation

RomanWuattier
Copy link
Contributor

@RomanWuattier RomanWuattier commented Jul 24, 2019

This commit creates the RxJavaTest class defining a default
timeout to 5 minutes. An ignored test announce itself for each
running class extending it preventing Travis CI from killing the
build.

Have Completable tests extend from RxJavaTest.
Have Disposable tests extend from RxJavaTest.
Have Exception tests extend from RxJavaTest

Related: #6583

@akarnokd akarnokd added this to the 3.0 milestone Jul 24, 2019
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #6589 into 3.x will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6589      +/-   ##
============================================
+ Coverage     98.16%   98.21%   +0.05%     
- Complexity     6183     6187       +4     
============================================
  Files           678      678              
  Lines         44908    44908              
  Branches       6214     6214              
============================================
+ Hits          44083    44107      +24     
+ Misses          278      268      -10     
+ Partials        547      533      -14
Impacted Files Coverage Δ Complexity Δ
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-2.39%) 2% <0%> (ø)
...tivex/internal/operators/single/SingleTimeout.java 98.33% <0%> (-1.67%) 2% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 94.7% <0%> (-1.59%) 3% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 96.25% <0%> (-1.07%) 5% <0%> (ø)
...ex/internal/operators/flowable/FlowableCreate.java 96.12% <0%> (-0.97%) 6% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 98.29% <0%> (-0.86%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 97.5% <0%> (-0.84%) 2% <0%> (ø)
...main/java/io/reactivex/subjects/ReplaySubject.java 96.68% <0%> (-0.42%) 50% <0%> (ø)
...internal/operators/flowable/FlowableConcatMap.java 98.5% <0%> (-0.38%) 6% <0%> (ø)
.../java/io/reactivex/processors/ReplayProcessor.java 98.97% <0%> (+0.4%) 52% <0%> (ø) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6c4b3...477394e. Read the comment docs.

@RomanWuattier RomanWuattier force-pushed the all-unit-tests-extend-base-class branch from 7b1fc00 to 4eb011f Compare July 24, 2019 20:45
@RomanWuattier
Copy link
Contributor Author

Thanks for updating the description and the review. I amended the commit to meet the new PR description.
I will cut the issue into a few more pull requests for simple readability reasons.

@RomanWuattier RomanWuattier marked this pull request as ready for review July 24, 2019 20:45
This commit creates the `RxJavaTest` class defining a default
timeout to 5 minutes. An ignored test announce itself for each
running class extending it preventing Travis CI from killing the
build.

Have `Completable` tests extend from `RxJavaTest`.
Have `Disposable` tests extend from `RxJavaTest`.
Have `Exception` tests extend from `RxJavaTest`

Related: ReactiveX#6583
@akarnokd
Copy link
Member

@RomanWuattier do you want to do the rest of the test classes in a separate PR?

@RomanWuattier
Copy link
Contributor Author

@akarnokd yes, you can merge this one when you want to.

@akarnokd akarnokd merged commit 663e5a2 into ReactiveX:3.x Jul 26, 2019
@RomanWuattier
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants