Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Expand the Javadoc of Flowable #6506

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

akarnokd
Copy link
Member

  • Add links to Reactive Streams
  • Fix hyphenation
  • Turn some @code into @links.
  • Add a short protocol description
  • Add basic example usage
  • Add example to use create for custom sources
  • Mention the synchronous/sequential nature and link in some operators.

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #6506 into 2.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                2.x   #6506      +/-   ##
===========================================
+ Coverage     98.26%   98.3%   +0.03%     
- Complexity     6295    6297       +2     
===========================================
  Files           675     675              
  Lines         45163   45163              
  Branches       6244    6244              
===========================================
+ Hits          44380   44397      +17     
+ Misses          248     237      -11     
+ Partials        535     529       -6
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 567 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 542 <0> (ø) ⬇️
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-2.39%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...tivex/internal/operators/single/SingleTimeout.java 98.33% <0%> (-1.67%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 95.42% <0%> (-1.31%) 2% <0%> (ø)
.../operators/mixed/FlowableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 2% <0%> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
...internal/operators/flowable/FlowableSwitchMap.java 95.75% <0%> (-0.95%) 3% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d506d...67396d2. Read the comment docs.

@akarnokd akarnokd merged commit ed29fac into ReactiveX:2.x Jun 17, 2019
@akarnokd akarnokd deleted the FlowableDocExpansion branch June 17, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants