Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc updates for RXJava Issue 6289 #6308

Merged
merged 2 commits into from
Nov 16, 2018

Conversation

pkamath2
Copy link
Contributor

Updates to io.reactivex.Flowable javadocs as per #6289.
Updated docs for all 6 Flowable.groupBy(...) methods.

@codecov
Copy link

codecov bot commented Nov 16, 2018

Codecov Report

Merging #6308 into 2.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6308      +/-   ##
============================================
+ Coverage     98.23%   98.23%   +<.01%     
+ Complexity     6284     6283       -1     
============================================
  Files           672      672              
  Lines         44992    44992              
  Branches       6223     6223              
============================================
+ Hits          44196    44197       +1     
+ Misses          252      250       -2     
- Partials        544      545       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 567 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 93.8% <0%> (-4.43%) 10% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 90.33% <0%> (-3.39%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-1.64%) 2% <0%> (ø)
...java/io/reactivex/processors/UnicastProcessor.java 98.8% <0%> (-1.2%) 67% <0%> (-1%)
...ernal/operators/flowable/FlowableFromIterable.java 96.25% <0%> (-1.07%) 5% <0%> (ø)
.../operators/mixed/FlowableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 2% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82b82e...00d7158. Read the comment docs.

@akarnokd akarnokd merged commit f800b30 into ReactiveX:2.x Nov 16, 2018
@pkamath2 pkamath2 deleted the flowable-javadoc-6289 branch November 17, 2018 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants