2.x: Cleaunp - rename fields to upstream and downstream #6129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #6129 +/- ##
============================================
- Coverage 98.23% 98.21% -0.03%
- Complexity 6194 6197 +3
============================================
Files 667 667
Lines 44853 44853
Branches 6213 6213
============================================
- Hits 44063 44054 -9
Misses 245 245
- Partials 545 554 +9
Continue to review full report at Codecov.
|
| @@ -68,14 +68,14 @@ | |||
|
|
|||
| /** | |||
| * Sets a Disposable on this emitter; any previous Disposable | |||
| * or Cancellation will be unsubscribed/cancelled. | |||
| * @param s the disposable, null is allowed | |||
| * or Cancellable will be disposed/cancelled. | |||
artem-zinnatullin
approved these changes
Aug 5, 2018
| @@ -26,11 +26,21 @@ | |||
| * <li>{@code TestObserver} named as {@code ts*}</li> | |||
| * <li>{@code PublishProcessor} named as {@code ps*}</li> | |||
| * <li>{@code PublishSubject} named as {@code pp*}</li> | |||
| * <li>{@code Subscription} with single letter name such as "s" or "d"</li> | |||
|
Thanks @artem-zinnatullin for your diligent review of this PR. |
|
👍 very helpful thanks |
| @@ -28,13 +28,13 @@ | |||
| public abstract class BasicFuseableObserver<T, R> implements Observer<T>, QueueDisposable<R> { | |||
|
|
|||
| /** The downstream subscriber. */ | |||
| protected final Observer<? super R> actual; | |||
There was a problem hiding this comment.
fyi these are protected fields so will break folks. We'll try and work around this, just saying. cc @kojilin
There was a problem hiding this comment.
|
In
src/main/java/io/reactivex/internal/observers/BasicFuseableObserver.java
<#6129 (comment)>:
Internal.
https://github.com/ReactiveX/RxJava#ioreactivexinternal
YIKES we have a lot of use of internal types, just didn't notice until you
mentioned. Will go through and rewrite a bunch of things. Thanks for the
pointer.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the field namings and some local variable namings:
upstreamfor the connectionDisposableorSubscriptioninstead ofd,s, etc., includingAtomicReference<*>declarations.downstreamfor the consumer field name in operators instead ofactualfor example.Disposable s->Disposable d, etc.The
CheckLocalVariablesInTestshas been extended with the relevant regexp checks.