Skip to content

Add marble diagrams to the Single.delay method #6076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2018
Merged

Add marble diagrams to the Single.delay method #6076

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddff1c2
Add marble diagrams to the Single.delay method
UMFsimke Jul 8, 2018
f7eb104
Update marbles for Single.delay with error events
UMFsimke Jul 8, 2018
627af51
Use correct marble diagram URLs for Single.delay methods
UMFsimke Jul 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update marbles for Single.delay with error events
  • Loading branch information
@UMFsimke
UMFsimke committed Jul 8, 2018
commit f7eb104805c0436f12efcca5b5b7d8b833021e16
4 changes: 2 additions & 2 deletions src/main/java/io/reactivex/Single.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1999,7 +1999,7 @@ public final Single<T> delay(long time, TimeUnit unit) {
/**
* Delays the emission of the success or error signal from the current Single by the specified amount.
* <p>
* <img width="640" height="457" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/Delay.png" alt="">
* <img width="640" height="457" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/DelayIncludingError.png" alt="">
* <dl>
* <dt><b>Scheduler:</b></dt>
* <dd>{@code delay} operates by default on the {@code computation} {@link Scheduler}.</dd>
Expand Down Expand Up @@ -2046,7 +2046,7 @@ public final Single<T> delay(final long time, final TimeUnit unit, final Schedul
/**
* Delays the emission of the success or error signal from the current Single by the specified amount.
* <p>
* <img width="640" height="457" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/DelayScheduler.png" alt="">
* <img width="640" height="457" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/DelaySchedulerIncludingError.png" alt="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also color the bottom arrows as orange to indicate they get executed on the provided scheduler.

* <dl>
* <dt><b>Scheduler:</b></dt>
* <dd>you specify the {@link Scheduler} where the non-blocking wait and emission happens</dd>
Expand Down