Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Maybe/Single Javadoc; annotation cleanup #5977

Merged
merged 1 commit into from
Apr 29, 2018

Conversation

akarnokd
Copy link
Member

The PR cleans up some wording around "Single source" and "Maybe source", plus removes some unnecessary annotations.

@codecov
Copy link

codecov bot commented Apr 29, 2018

Codecov Report

Merging #5977 into 2.x will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5977      +/-   ##
============================================
- Coverage     98.26%   98.24%   -0.02%     
- Complexity     6051     6053       +2     
============================================
  Files           656      656              
  Lines         44077    44077              
  Branches       6118     6118              
============================================
- Hits          43312    43304       -8     
- Misses          228      232       +4     
- Partials        537      541       +4
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 146 <0> (ø) ⬇️
src/main/java/io/reactivex/Maybe.java 100% <ø> (ø) 171 <0> (ø) ⬇️
...ava/io/reactivex/processors/BehaviorProcessor.java 95.96% <0%> (-3.14%) 59% <0%> (-1%)
.../operators/observable/ObservableFlatMapSingle.java 91.79% <0%> (-2.99%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 95.83% <0%> (-2.5%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...l/operators/observable/ObservableFlatMapMaybe.java 88.88% <0%> (-1.31%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 90.82% <0%> (-0.97%) 2% <0%> (ø)
...operators/observable/ObservableMergeWithMaybe.java 99.1% <0%> (-0.9%) 2% <0%> (ø)
...l/operators/observable/ObservableTimeoutTimed.java 99.15% <0%> (-0.85%) 3% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b929c4...20a1c5b. Read the comment docs.

@akarnokd akarnokd merged commit dc94f56 into ReactiveX:2.x Apr 29, 2018
@akarnokd akarnokd deleted the JavadocCleanup0429 branch April 29, 2018 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants