Skip to content

Operation Sample with Observable v2 #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjchristensen merged 1 commit into from
Dec 8, 2013
Merged

Operation Sample with Observable v2 #571

benjchristensen merged 1 commit into from
Dec 8, 2013

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 6, 2013

Issue #74

  • Sample will terminate if either the source or the sampler terminates or throws an error.
  • The sampler now emits values only in its onNext() method. Therefore, if the sampler completes and there is a sampled value available (valueTaken == false), it won't emit the value before terminating.

@cloudbees-pull-request-builder
Copy link

cloudbees-pull-request-builder commented Dec 6, 2013

RxJava-pull-requests #506 SUCCESS
This pull request looks good

benjchristensen added a commit that referenced this pull request Dec 8, 2013
@benjchristensen
Merge pull request #571 from akarnokd/SampleWithObservable2
53787f2 
Operation Sample with Observable v2
@benjchristensen benjchristensen merged commit 53787f2 into ReactiveX:master Dec 8, 2013
@benjchristensen benjchristensen mentioned this pull request Dec 11, 2013
Closed
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
@benjchristensen
Merge pull request ReactiveX#571 from akarnokd/SampleWithObservable2
3eea8ad 
Operation Sample with Observable v2
@akarnokd akarnokd deleted the SampleWithObservable2 branch January 13, 2014 10:03
@kboyarshinov kboyarshinov mentioned this pull request Jan 31, 2016
Closed
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
@RobWin
Issue ReactiveX#571: Spring Boot 1 and Spring Boot 2 custom endpoints…
dcaeb44 
… should not be mandatory. (ReactiveX#572)
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
@dlsrb6342 @RobWin
Issue ReactiveX#571: Spring Boot HealthIndicators use the registries now
f8d0e5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akarnokd @cloudbees-pull-request-builder @benjchristensen