2.x: Remove some dead code #4581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
approved these changes
Sep 22, 2016
| @@ -28,6 +28,7 @@ | |||
| @Retention(RetentionPolicy.RUNTIME) | |||
| @Documented | |||
| @Target({ElementType.METHOD, ElementType.TYPE}) | |||
| @SuppressWarnings("unused") // Part of Public API. | |||
| public @interface SchedulerSupport { | |||
There was a problem hiding this comment.
I guess IntelliJ complains about this? Now Eclipse will.
There was a problem hiding this comment.
Well IO & NEW_THREAD are unused since they are not used internally. However they're part of the public API so I suppressed that warning that they're not used. Why will Eclipse complain about this one?
There was a problem hiding this comment.
Because it doesn't see anything, like a private method that is not in use.
There was a problem hiding this comment.
Oh that's really bad. You want me to remove this one or leave it as is?
Current coverage is 78.01% (diff: 100%)@@ 2.x #4581 diff @@
==========================================
Files 552 552
Lines 36164 36156 -8
Methods 0 0
Messages 0 0
Branches 5575 5574 -1
==========================================
- Hits 28215 28208 -7
+ Misses 5934 5929 -5
- Partials 2015 2019 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also what about IntFunction it's right now in the public API however not used. So the question is does Rx want to expose that interface?