2.x: count, elementAt, ingoreElements, last, single, reduce, reduceWith to return non-Flowable #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to return non-Flowable
Current coverage is 78.42% (diff: 77.05%)@@ 2.x #4576 diff @@
==========================================
Files 538 545 +7
Lines 35686 35941 +255
Methods 0 0
Messages 0 0
Branches 5516 5548 +32
==========================================
+ Hits 28049 28185 +136
- Misses 5634 5737 +103
- Partials 2003 2019 +16
|
JakeWharton
approved these changes
Sep 21, 2016
| public final Flowable<T> first() { | ||
| return take(1).single(); | ||
| public final Maybe<T> firstElement() { | ||
| return elementAt(0); |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates many
Flowableoperators to returnSingle,MaybeorCompletable:count()->SingleelementAt()->MaybeelementAt(T)->Singlefirst(T)->SinglefirstElement()->MaybeignoreElements()->Completablereduce(Callable, BiFunction)->SinglereduceWith(U, BiFunction)->Singlesingle(T)->SinglesingleElement()->Maybeand deletes
Flowable.toSingle,Flowable.toMaybeandFlowable.toCompletable.Flowble.reduce(BiFunction)was not yet changed fromSingletoMaybe(to allow empty sources to be reduced to empty Maybe).Related: #4321