Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: add more Maybe operators 9/09-1 #4519

Merged
merged 1 commit into from
Sep 9, 2016
Merged

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Sep 9, 2016

This PR adds some more Maybe operators:

  • ambWith
  • cache
  • concatWith
  • contains
  • count
  • defaultIfEmpty
  • delay
  • switchIfEmpty
  • zipWith

Plus a small cleanup and additional TestHelper test support (check double onSubscribe calls, dispose() state management).

@akarnokd akarnokd added this to the 2.0 RC 3 milestone Sep 9, 2016
@codecov-io
Copy link

codecov-io commented Sep 9, 2016

Current coverage is 78.73% (diff: 98.21%)

Merging #4519 into 2.x will increase coverage by 0.20%

@@                2.x      #4519   diff @@
==========================================
  Files           507        512     +5   
  Lines         34386      34609   +223   
  Methods           0          0          
  Messages          0          0          
  Branches       5395       5425    +30   
==========================================
+ Hits          27003      27250   +247   
+ Misses         5411       5392    -19   
+ Partials       1972       1967     -5   

Powered by Codecov. Last update 4f878d5...8f8fce7

/**
* Verifies that instance methods of the base reactive classes are all declared final.
*/
public class PublicFinalMethods {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, nice

@JakeWharton
Copy link
Contributor

👍

@akarnokd akarnokd merged commit db8b733 into ReactiveX:2.x Sep 9, 2016
@akarnokd akarnokd deleted the MaybeOps909_1 branch September 9, 2016 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants