2.x: Completable enhance doOnEvent to reduce allocations #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return doOnLifecycle(Functions.emptyConsumer(), Functions.emptyConsumer(), | ||
| onComplete, Functions.EMPTY_ACTION, | ||
| Functions.EMPTY_ACTION, Functions.EMPTY_ACTION); | ||
| public final Completable doOnComplete(final Action onComplete) { |
There was a problem hiding this comment.
Why? There was no extra allocations here as the others are just static instances.
There was a problem hiding this comment.
How is this any different from this?
There was a problem hiding this comment.
Looks like that comment was misaligned. You changed SingleDoOnEvent to have 2 arguments and then had 2 allocations to work with BiConsumer.
Current coverage is 78.19% (diff: 70.83%)@@ 2.x #4486 diff @@
==========================================
Files 494 495 +1
Lines 33661 33679 +18
Methods 0 0
Messages 0 0
Branches 5290 5290
==========================================
+ Hits 26319 26335 +16
+ Misses 5381 5377 -4
- Partials 1961 1967 +6
|
vanniktech
changed the title
|
@akarnokd this is the way it is desired now, correct? |
|
Great! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.