2.x: Flowable.reduce() to return Single, macro fusion #4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 78.12% (diff: 68.08%)@@ 2.x #4484 diff @@
==========================================
Files 494 496 +2
Lines 33661 33754 +93
Methods 0 0
Messages 0 0
Branches 5290 5303 +13
==========================================
+ Hits 26319 26371 +52
- Misses 5381 5415 +34
- Partials 1961 1968 +7
|
|
👍 |
| * </pre> | ||
| * | ||
| * The {@code Single.toObservable()} will check for this interface and call the {@link #fuseToObservable()} | ||
| * to return a Flowable which could be the Flowable-specific implementation of reduce(BiFunction). | ||
| * to return a Observable which could be the Observable-specific implementation of reduce(BiFunction). |
There was a problem hiding this comment.
Thanks, fixing it here and all the ~400 errors in Observable itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the baseline for changing
FlowableandObservableoperators to returnSingle,CompletableorMaybebut in case the user wants to go back to the original type viatoFlowableortoObservablewe switch to a nativelyFlowable/Observableoperator (macro-fusion).Benchmark comparison (i7 4790, Windows 7 x64, Java 8u102):
No changes were applied to
Observableyet hence the roughly same result there.Flowable.reduce()has been updated plus there is a newFlowableReduceinstead ofscan().last().