2.x: rename Observable and Single #doOnCancel to #doOnDispose #4458
Conversation
| public final Single<T> doOnCancel(final Action onCancel) { | ||
| ObjectHelper.requireNonNull(onCancel, "onCancel is null"); | ||
| return RxJavaPlugins.onAssembly(new SingleDoOnCancel<T>(this, onCancel)); | ||
| public final Single<T> doOnDispose(final Action onDispose) { |
There was a problem hiding this comment.
should not we deprecate doOnCancel and then remove it with RC3?
There was a problem hiding this comment.
I think the discussion #4451 came to a consensus that no need for going soft but delete what's no longer needed before releasing RC2, hence no deprecation.
There was a problem hiding this comment.
Alright works for me too
|
The diff for observable doesn't show but the offline-comparison only lists 30-40 lines changes. Did you run some whitespace cleanup? |
|
@akarnokd Whoops, you're right. Sorry. Auto formatter seems to have changed some whitespaces. I'll revert that. |
Current coverage is 75.94% (diff: 100%)@@ 2.x #4458 diff @@
==========================================
Files 485 485
Lines 33042 33042
Methods 0 0
Messages 0 0
Branches 5240 5240
==========================================
+ Hits 25082 25093 +11
+ Misses 5915 5909 -6
+ Partials 2045 2040 -5
|
|
👍 |
akarnokd
changed the title
|
This update is missing in release notes on GitHub. Please, remember to mention such changes in the future. |
#4456
Completable already used .doOnDispose() however I renamed the arguments to match Observable and Single