2.x: Subject/Processor improvements & small cleanup #4437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 75.02% (diff: 80.16%)@@ 2.x #4437 diff @@
==========================================
Files 453 454 +1
Lines 32399 32271 -128
Methods 0 0
Messages 0 0
Branches 5216 5208 -8
==========================================
- Hits 24336 24212 -124
- Misses 6034 6039 +5
+ Partials 2029 2020 -9
|
| * @throws IllegalArgumentException if bufferSize <= 0 | ||
| */ | ||
| private static void verifyPositive(int value, String paramName) { | ||
| protected static int verifyPositive(int value, String paramName) { |
There was a problem hiding this comment.
These aren't high-value APIs and are trivial to replicate with
if (value < 0) throw new IllegalArgumentException("value < 0: " + value);I would prefer they be moved somewhere in internal and made public for use all over the library but not be exposed in the library's public API.
|
thanks 👍 |
akarnokd
force-pushed
the
CleanupAndImprovements829_1
branch
from
24740b8 to
09a3448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verifyPositiveas protected for validation convenience in subclassesDeferredScalarSubscriptionAsyncSubjectandAsyncProcessor, compact the classesAsyncX.hasValue()returns false until the terminal state has been reachedPublishSubject,PublishProcessor,BehaviorSubject,BehaviorProcessor,ReplaySubjectandReplayProcessorUnicastSubject, compact the classBaseXQueueDisposabletoBasicXQueueDisposableto matchBasicXQueueSubscriptionDeferredScalarDisposable, refactorDeferredScalarObservernew PublishSubject<>(); there is no mandatory shared state between theObserverpart and theObservablepart because both are now stateless on their own.