2.x: cleanup, behavior clarifications, fixes, coverage 8/28-1 #4435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 75.11% (diff: 94.80%)@@ 2.x #4435 diff @@
==========================================
Files 453 453
Lines 32373 32399 +26
Methods 0 0
Messages 0 0
Branches 5220 5216 -4
==========================================
+ Hits 23852 24337 +485
+ Misses 6435 6037 -398
+ Partials 2086 2025 -61
|
| @@ -42,6 +42,7 @@ public ListCompositeDisposable(Disposable... resources) { | |||
|
|
|||
| public ListCompositeDisposable(Iterable<? extends Disposable> resources) { | |||
| ObjectHelper.requireNonNull(resources, "resources is null"); | |||
| this.resources = new LinkedList<Disposable>(); | |||
There was a problem hiding this comment.
nit: initialize with resources size?
There was a problem hiding this comment.
Also iterables do not expose their size anyway. Only collections.
This saves methods for Android as well. I wanted to see how many were being added before pressing the issue about this convention, but nice to see there's another motivation for not using enums here. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestObserverDisposableHelperand its innerDisposedenumNotificationLiteand its innerCompleteenumListCompositeDisposableconstructorDeferredScalarObserverfusion and state managementTestObserver.awaitDone(), one should always await with timeout