Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: fixes, cleanups, renames #4421

Merged
merged 2 commits into from
Aug 24, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/main/java/io/reactivex/Completable.java
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ public static Completable never() {
}

/**
* Returns a Completable instance that fires its onComplete event after the given delay ellapsed.
* Returns a Completable instance that fires its onComplete event after the given delay elapsed.
* <dl>
* <dt><b>Scheduler:</b></dt>
* <dd>{@code timer} does operate by default on the {@code computation} {@link Scheduler}.</dd>
Expand All @@ -592,7 +592,7 @@ public static Completable timer(long delay, TimeUnit unit) {
}

/**
* Returns a Completable instance that fires its onComplete event after the given delay ellapsed
* Returns a Completable instance that fires its onComplete event after the given delay elapsed
* by using the supplied scheduler.
* <dl>
* <dt><b>Scheduler:</b></dt>
Expand Down Expand Up @@ -815,7 +815,7 @@ public final void blockingAwait() {
* @param timeout the timeout value
* @param unit the timeout unit
* @return true if the this Completable instance completed normally within the time limit,
* false if the timeout ellapsed before this Completable terminated.
* false if the timeout elapsed before this Completable terminated.
* @throws RuntimeException wrapping an InterruptedException if the current thread is interrupted
*/
@SchedulerSupport(SchedulerSupport.NONE)
Expand All @@ -840,12 +840,12 @@ public final Throwable blockingGet() {

/**
* Subscribes to this Completable instance and blocks until it terminates or the specified timeout
* ellapses, then returns null for normal termination or the emitted exception if any.
* elapses, then returns null for normal termination or the emitted exception if any.
* @param timeout the timeout value
* @param unit the time unit
* @return the throwable if this terminated with an error, null otherwise
* @throws RuntimeException that wraps an InterruptedException if the wait is interrupted or
* TimeoutException if the specified timeout ellapsed before it
* TimeoutException if the specified timeout elapsed before it
*/
@SchedulerSupport(SchedulerSupport.NONE)
public final Throwable blockingGet(long timeout, TimeUnit unit) {
Expand Down Expand Up @@ -957,7 +957,7 @@ public final Completable doOnComplete(Action onComplete) {
}

/**
* Returns a Completable which calls the giveon onDispose callback if the child subscriber cancels
* Returns a Completable which calls the given onDispose callback if the child subscriber cancels
* the subscription.
* <dl>
* <dt><b>Scheduler:</b></dt>
Expand Down Expand Up @@ -1069,9 +1069,13 @@ public final Completable doOnTerminate(final Action onTerminate) {
*/
@SchedulerSupport(SchedulerSupport.NONE)
public final Completable doAfterTerminate(final Action onAfterTerminate) {
return doOnLifecycle(Functions.emptyConsumer(), Functions.emptyConsumer(),
onAfterTerminate, Functions.EMPTY_ACTION,
Functions.EMPTY_ACTION, Functions.EMPTY_ACTION);
return doOnLifecycle(
Functions.emptyConsumer(),
Functions.emptyConsumer(),
Functions.EMPTY_ACTION,
Functions.EMPTY_ACTION,
onAfterTerminate,
Functions.EMPTY_ACTION);
}

/**
Expand Down Expand Up @@ -1618,7 +1622,7 @@ public final <T> Observable<T> toObservable() {
}

/**
* Convers this Completable into a Single which when this Completable completes normally,
* Converts this Completable into a Single which when this Completable completes normally,
* calls the given supplier and emits its returned value through onSuccess.
* <dl>
* <dt><b>Scheduler:</b></dt>
Expand All @@ -1636,7 +1640,7 @@ public final <T> Single<T> toSingle(final Callable<? extends T> completionValueS
}

/**
* Convers this Completable into a Single which when this Completable completes normally,
* Converts this Completable into a Single which when this Completable completes normally,
* emits the given value through onSuccess.
* <dl>
* <dt><b>Scheduler:</b></dt>
Expand Down
Loading