1.x: add RxJavaHooks tests, fix small bugs #4142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 81.47%@@ 1.x #4142 diff @@
==========================================
Files 257 257
Lines 16811 16823 +12
Methods 0 0
Messages 0 0
Branches 2547 2550 +3
==========================================
+ Hits 13658 13707 +49
+ Misses 2247 2218 -29
+ Partials 906 898 -8
|
src/main/java/rx/Completable.java
Outdated
| * not null (not verified) | ||
| * @param noHook if true, RxJavaHooks.onCreate won't be called | ||
| */ | ||
| private Completable(CompletableOnSubscribe onSubscribe, boolean noHook) { |
Contributor
There was a problem hiding this comment.
Can we make positive boolean variable, useHook?
Member
Author
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the new
RxJavaHooksfacility and fixesCompletablesources such ascomplete()andnever(): they executed the hook on class initialization so they couldn't be properly overridden later via anonCreatehook. (This could affect the other constants and will be addressed separately.)