Remove XResource classes #4126
Merged
Remove XResource classes #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 69.56%@@ 2.x #4126 diff @@
==========================================
Files 384 383 -1
Lines 27125 27074 -51
Methods 0 0
Messages 0 0
Branches 4364 4355 -9
==========================================
- Hits 18896 18834 -62
- Misses 6327 6349 +22
+ Partials 1902 1891 -11
|
| @@ -15,6 +15,9 @@ | |||
| import org.reactivestreams.Subscription; | |||
|
|
|||
| final class SubscriptionDisposable extends ReferenceDisposable<Subscription> { | |||
| /** */ | |||
| private static final long serialVersionUID = -707001650852963139L; | |||
There was a problem hiding this comment.
What are these for? We shouldn't be encouraging people to serialize these instances.
There was a problem hiding this comment.
Eclipse complains about serializable classes (i.e., extending AtomicX) need these fields, even though we don't care about serialization. A small inconvenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
XResourcetypes and replaces them withXDisposableorXSubscriptionwhere necessary.