2.x: Expose isDisposed method on Disposable. #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a bunch of compilation errors: https://travis-ci.org/ReactiveX/RxJava/builds/139948754#L315 |
|
Probably missing imports. I have to edit those by hand in each file so the On Fri, Jun 24, 2016 at 2:59 AM David Karnok notifications@github.com
|
Current coverage is 69.85%@@ 2.x #4102 diff @@
==========================================
Files 380 380
Lines 26985 27087 +102
Methods 0 0
Messages 0 0
Branches 4331 4356 +25
==========================================
- Hits 18928 18921 -7
- Misses 6144 6252 +108
- Partials 1913 1914 +1
|
|
👍 Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly "dumb" addition. There's lots of room for follow-up improvement in the utilization of base helper classes and even removing some now-duplicated state management.
Closes #4075.