2.x: full JDK 6 compatible backport + including bugfixes up to today #3668
Conversation
|
This is basically unreviewable, so I vote that it is just merged. People can go through the code base passively and bring up any issues/questions/etc. as they're discovered. |
|
It's not possible incrementally anyway, i.e., by using our own Function, it affects all operators that take Function. |
|
👍 Agree |
| } | ||
|
|
||
| public T get() { | ||
| return value; |
There was a problem hiding this comment.
This method throws exception if value is null in JDK 8'th impl, is this intended, @akarnokd?
There was a problem hiding this comment.
By us, it's of that throws before even creating the optional.
There was a problem hiding this comment.
Code can (through abstraction) end up doing Optional.empty().get() which leaks a null reference into the system though.
There was a problem hiding this comment.
Yup, exactly, deserves a throw in my opinion, to prevent leaking that null into user's code.
Also
There was a problem hiding this comment.
Agree, of and get need to check for null.
|
I'm ok for merging it as is. |
|
👍 for all of this |
2.x: full JDK 6 compatible backport + including bugfixes up to today
|
Merged. Happy reviewing! |
Due to the issue with AtomicXFieldUpdaters on certain Android devices, I had to manually replace all of them with regular AtomicX classes.