Skip to content

Update CHANGES.md for v1.0.16 #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stealthcode merged 1 commit into from
Nov 11, 2015
Merged

Update CHANGES.md for v1.0.16 #3517

stealthcode merged 1 commit into from
Nov 11, 2015

Conversation

@stealthcode
Copy link

@stealthcode stealthcode commented Nov 11, 2015

No description provided.

@artem-zinnatullin
Copy link
Contributor

artem-zinnatullin commented Nov 11, 2015

👍

JakeWharton
JakeWharton reviewed Nov 11, 2015
View reviewed changes
CHANGES.md Outdated
Copy link
Contributor

@JakeWharton JakeWharton Nov 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't public API. Shouldn't need to mention.

@stealthcode
Copy link
Author

stealthcode commented Nov 11, 2015

@abersnaze @benjchristensen @akarnokd @zsxwing @stevegury

JakeWharton
JakeWharton reviewed Nov 11, 2015
View reviewed changes
CHANGES.md Outdated
Copy link
Contributor

@JakeWharton JakeWharton Nov 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably read Replace all instances of Atomic*FieldUpdater with direct Atomic* instances or something.

Copy link
Author

@stealthcode stealthcode Nov 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@artem-zinnatullin artem-zinnatullin Nov 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it was internal change too :) If we want to show what this PR means to the users — we can write something like: "Replace … (fixes crashes on some Samsung devices Running on Android 5)".

@stealthcode stealthcode force-pushed the changesmd-v1.0.16 branch 2 times, most recently from 71ee3cd to 211589f Compare November 11, 2015 20:42
@akarnokd
Copy link
Member

akarnokd commented Nov 11, 2015

Can we get #3493 in as well?

@stealthcode
Copy link
Author

stealthcode commented Nov 11, 2015

Merged #3493 and updated.

@akarnokd
Copy link
Member

akarnokd commented Nov 11, 2015

👍

@abersnaze
Copy link
Contributor

abersnaze commented Nov 11, 2015

LGTM 👍

stealthcode pushed a commit that referenced this pull request Nov 11, 2015
Merge pull request #3517 from ReactiveX/changesmd-v1.0.16
33340c5 
Update CHANGES.md for v1.0.16
@stealthcode stealthcode merged commit 33340c5 into 1.x Nov 11, 2015
@stealthcode
Copy link
Author

stealthcode commented Nov 11, 2015

Thanks @akarnokd @abersnaze @JakeWharton @artem-zinnatullin

@JakeWharton
Copy link
Contributor

JakeWharton commented Nov 11, 2015

No. Thanks to you maintainers for pushing these along!

edit: punctuation matters

On Wed, Nov 11, 2015 at 4:03 PM Aaron Tull notifications@github.com wrote:

Thanks @akarnokd https://github.com/akarnokd @abersnaze
https://github.com/abersnaze @JakeWharton
https://github.com/JakeWharton @artem-zinnatullin
https://github.com/artem-zinnatullin

—
Reply to this email directly or view it on GitHub
#3517 (comment).

@akarnokd akarnokd deleted the changesmd-v1.0.16 branch November 11, 2015 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stealthcode @artem-zinnatullin @akarnokd @abersnaze @JakeWharton