Make Publish Operator Release RingBuffer #2237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it was retaining the RxRingBuffer reference between subscribes which meant it was never released to the object pool
benjchristensen
added a commit
that referenced
this pull request
Dec 24, 2014
Make Publish Operator Release RingBuffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was retaining the RxRingBuffer reference between subscribes which meant it was never released to the object pool.
As per discussion in #2189 there are other issues in the
OperatorPublishimplementation but those will be fixed later. This PR is just for fixing the issue related to use of RxRingBuffer.