-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cvitek/c906_little #8514
add cvitek/c906_little #8514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请仔细review代码
bsp/cvitek/c906_little/board/board.c
Outdated
#include <rtthread.h> | ||
|
||
#include "board.h" | ||
// rt_uint8_t test_heap[1024*32]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
移除无效注释代码
|
||
static void plic_enable_irq(int irq) | ||
{ | ||
// *(uint32_t *)PLIC_ENABLE(irq) = *(uint32_t *)PLIC_ENABLE(irq) | (0x1 << (irq % 32)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
移除
{ | ||
int i; | ||
|
||
for (i = 0; i < IRQ_MAX_NR / 4; i = i + 4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件代码风格是需要整理的
bsp/cvitek/c906_little/board/types.h
Outdated
@@ -0,0 +1,43 @@ | |||
/* SPDX-License-Identifier: GPL-2.0 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注意许可协议
/* */ | ||
/* Version: */ | ||
/* */ | ||
/* Copyright (c) 2010-2016 Xilinx, Inc. All rights reserved. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件的注释太怪异了
@@ -0,0 +1,30 @@ | |||
CONFIG_SYS_TEXT_BASE = 0x80200000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要确定这些符号哪里会使用到
5a6099c
to
03c781d
Compare
88a52d2
to
2116659
Compare
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
新增 cvitek bsp下小核
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
cvitek
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up