Update plugin to latest Gradle standards #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Current Gradle version is 7.5.1 - Minimal supported version is now 6.6 6.6+ is needed tow write tasks as abstract classes with abstract getters. The build now uses the Kotlin DSL so that the `embedded-kotlin` plugin can be used to compile/run against the Kotlin version embedded in Gradle (this is not supported in Groovy DSL right now).
|
@jjohannes : Thank you for the contribution and the helpful description. I intend to test the changes in a project where I use this plugin and then release a new version in the next few days. |
REPLicated
reviewed
Nov 22, 2022
src/main/kotlin/io/fuchs/gradle/collisiondetector/CollisionDetectorPlugin.kt
Show resolved
Hide resolved
This makes sure that even if another JDK version is used to build the plugin (e.g. in an environment where jenv is not installed) the version stored in the '.java-version' file is used as target.
REPLicated
reviewed
Nov 25, 2022
|
Thank you @REPLicated for integrating this and releasing a new version! |
|
@REPLicated just want to let you know that I show the plugin in the video in case you ever want to use that: https://youtu.be/KocTqF0hO_8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@REPLicated I was looking for a simple solution (before I build one myself) that scans a classpath for duplicates. Yours is exactly what I was looking for. I think something like this should be used by much more projects.
I found a few things to update to make it follow latest Gradle standards and make it compatible with the new Configuration Cache feature. Would you be interested in integrating this and release a new version?
Background
I am doing a series of videos about the Classpath and related concepts in Gradle (first part here) and need something like this there soon. And I maintain a GitHub project where I show how latest Gradle features may be used to get rid of dependency chaos - there I would also like to add this plugin (or something similar).
About the changes in this PR:
Note: 6.6+ is needed tow write tasks as abstract classes with abstract getters.
The build now uses the Kotlin DSL so that the
embedded-kotlinplugin can be used to compile/run against the Kotlin version embedded in Gradle (this is not supported in Groovy DSL right now).