Skip to content

Conversation

@agriyakhetarpal
Copy link
Collaborator

@agriyakhetarpal agriyakhetarpal commented Mar 11, 2024

Description

This PR updates the emscripten.yml workflow to establish uploads of nightly WASM wheels on an Anaconda-hosted PyPI index at https://anaconda.org/scientific-python-nightly-wheels/pywavelets.

With the configuration set here, this shall overwrite existing wheels if present.

Proposed changes

The changes here are as follows:

  1. A schedule to upload wheels
  2. A workflow_dispatch event to trigger manual uploads if needed
  3. A step with conditions set so that the cadence of the wheel upload adheres to a push to master, a manually-triggered workflow, and on this repository only – not on forks

Footnotes

Please see #706 for more information.

This closes scientific-python/upload-nightly-action#75.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems straightforward enough, thanks @agriyakhetarpal. I guess we'll only know if it works once we merge and try an upload, so let's do that proactively - I only have a minor comment so far.

@rgommers rgommers added the CI Continuous integration label Mar 11, 2024
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's give this a go now

@rgommers rgommers merged commit 52ce35f into PyWavelets:master Mar 12, 2024
@agriyakhetarpal agriyakhetarpal deleted the upload-wasm-nightlies branch March 12, 2024 10:35
@agriyakhetarpal
Copy link
Collaborator Author

It worked, we have the wheel at https://anaconda.org/scientific-python-nightly-wheels/PyWavelets/files

@rgommers
Copy link
Member

Great! Everything in the CI log looks as expected too, so we're all set here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request access for PyWavelets

3 participants