Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Fix #148: Adding .editorconfig and other VSCode recommendations #146

Merged
merged 4 commits into from
Nov 1, 2018
Merged

Fix #148: Adding .editorconfig and other VSCode recommendations #146

merged 4 commits into from
Nov 1, 2018

Conversation

Tiberriver256
Copy link
Contributor

@Tiberriver256 Tiberriver256 commented Nov 1, 2018 •
edited
Loading

  • .editorconfig to ease the headache of odd formatting issues across editors and OSes
  • formatOnSave to true in settings.json to ensure PowerShell code is formatted consistently and without having to think about it
  • Added the following recommended extensions for VSCode
  • Fixed a little bug in the tasks.json file. We were missing a slash which turned a comment into a not comment...

Related issue: #148

@Tiberriver256 Tiberriver256 changed the title Adding .editorconfig and other VSCode recommendations Fix #148: Adding .editorconfig and other VSCode recommendations Nov 1, 2018
TylerLeonhardt
TylerLeonhardt reviewed Nov 1, 2018
View reviewed changes
TylerLeonhardt
TylerLeonhardt approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one tiny nitpick 😄

TylerLeonhardt
TylerLeonhardt reviewed Nov 1, 2018
View reviewed changes
@TylerLeonhardt @Tiberriver256
Update .editorconfig
a8e1683 
Co-Authored-By: Tiberriver256 <Micah.rairdon@gmail.com>
@Tiberriver256 Tiberriver256 merged commit d7a0bdd into PowerShell:master Nov 1, 2018
@Tiberriver256 Tiberriver256 deleted the adding-editor-config branch November 2, 2018 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tiberriver256 @TylerLeonhardt