-
Notifications
You must be signed in to change notification settings - Fork 113
Fix #148: Added git attributes for Line Endings #142
Conversation
Nice, I was thinking about adding in something like this as well. Another great addition if you want to throw it in there would be a .editorconfig file. This would take care of configuring any editors (VSCode / Vim) to use LF when they are creating new files within a project. And probably a .vscode folder with an extensions.json file with the following content: {
"recommendations": [
"EditorConfig.EditorConfig"
]
}
This way VSCode users would get prompted to install the editorconfig extension to work with the .editorconfig file. This will help a lot I think to make it easier for people to work across development environments. Thank you for thinking of this! If you don't want to mess with the editorconfig just let me know. I can set it up and do a separate pull request. This is great. |
I will take a look next week and see if I can add the editor file as well. Thanks! |
Actually @Tiberriver256 I think I will hold off on the .editorconfig file for now. Do you think you could take a look? I've been working on getting ADFS/OpenID/Oauth working 😊 |
Cool yeah that's no worry. I can grab it. @tylerl0706 do you know of an easy way to re-trigger to build? Looks like the ubuntu image wasn't available for some reason during the last attempt otherwise I think we can merge this in. |
.gitattributes
Outdated
|
||
*.ps1 text eol=lf | ||
*.psd1 text eol=lf | ||
*.psm1 text eol=lf No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: add a new line at the end of this file. It's usually best practice.
re kicked the build! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just a small nitpick.
Also, the ps1 and psd1... is that changing the line endings of those files? Otherwise, they're identical right?
Co-Authored-By: jeremymcgee73 <jeremymcgee6@gmail.com>
Can someone just double check the Line Endings on the files? I just want to make sure I'm changing the back to LF and not to CRLF. @tylerl0706 @Tiberriver256 Thanks! |
Nope you're good. The Polaris.psd1 looks like the only one that got switched to CRLF at one point or another and it looks to be LF in your repository now. Thank you! |
I was having issues with Line Endings with git and VSC. I added a git attribute file so that git will know what line endings to use with PowerShell files in this repo. I believe this will make other contributors lives a bit easier.
I followed this blog post.
*Edit for maintainer:
Related issue #148