Skip to content

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Nov 6, 2018

PR Summary

Fixes #1095 as reported by @alatas (I could reproduce locally, see tests). Thanks for the detailed report.
This is an alternative to #1096 that seems to cause problems in CI, this approach is using ToLowerInvariant instead.

PR Checklist

@bergmeister bergmeister changed the title WIP Fix parsing error that occurs when using turkish culture and Invoke-Formatter Fix culture issue error that occurs when using turkish culture and Invoke-Formatter Nov 6, 2018
@bergmeister bergmeister requested a review from rjmholt November 6, 2018 21:04
@bergmeister bergmeister added this to the 1.18 milestone Nov 6, 2018
@bergmeister bergmeister self-assigned this Nov 6, 2018
@bergmeister
Copy link
Collaborator Author

bergmeister commented Nov 12, 2018

I will close this in favour of PR #1099 which has a better, more generic solution to culture in general and addresses other culture issues as well

@bergmeister bergmeister removed the request for review from rjmholt November 12, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An exception is thrown when CurrentCulture is Turkish (tr-TR)

1 participant