Skip to content

Fix child expand #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2023
Merged

Fix child expand #223

merged 3 commits into from
Oct 27, 2023

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Oct 27, 2023

PR Summary

Fixes #222

PR Context

This fixes a bug where:

  • You could unexpectedly expand what should be leaf nodes of tree (CanExpand returns false)
  • Expanding revealed static members (e.g. Int32.MaxValue)

andyleejordan
andyleejordan approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

@andyleejordan andyleejordan enabled auto-merge (squash) October 27, 2023 17:25
@andyleejordan andyleejordan merged commit 78930cc into PowerShell:master Oct 27, 2023
@tznind tznind deleted the fix-child-expand branch October 27, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Seemingly) Infinitely nesting properties in Show-ObjectTree
2 participants
@tznind @andyleejordan