Skip to content

Conversation

@romeroalx
Copy link
Member

Short description

This PR fixes the pattern used in download-artifacts to make it more complete. Issue found when running build-packages-daily-releases.yml (here)

In addition, there are cases where another job has published the version that was being published (see error). A retry mechanism is added to avoid this.

Finally, the process of uploading files is split into two steps: uploading an artifact and creating the file object, and the internal chunk-size is set the same for File and DEB objects as it is for RPMs.

Test: https://github.com/romeroalx/pdns/actions/runs/18901704327

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@romeroalx romeroalx added github_actions Pull requests that update GitHub Actions code ci labels Oct 29, 2025
@coveralls
Copy link

coveralls commented Oct 29, 2025

Pull Request Test Coverage Report for Build 18903493638

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6670 unchanged lines in 81 files lost coverage.
  • Overall coverage remained the same at 73.004%

Files with Coverage Reduction New Missed Lines %
pdns/recursordist/rec-rust-lib/rust/src/bridge.hh 1 0.0%
pdns/recursordist/sortlist.hh 1 75.0%
pdns/dnsname.hh 2 92.79%
pdns/dnstap.cc 2 72.73%
pdns/recursordist/secpoll-recursor.cc 2 52.81%
modules/gpgsqlbackend/spgsql.cc 3 67.94%
pdns/ednscookies.hh 3 72.73%
pdns/rcpgenerator.cc 3 90.71%
pdns/recursordist/rec-nsspeeds.hh 3 90.59%
pdns/dnsdistdist/dnsdist-tcp.cc 4 77.4%
Totals Coverage Status
Change from base Build 18832893357: 0.0%
Covered Lines: 127434
Relevant Lines: 163861

💛 - Coveralls

@romeroalx romeroalx merged commit 9769584 into PowerDNS:master Oct 30, 2025
161 of 164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants