Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 517: Modernize pycti build #243

Merged
merged 27 commits into from
Feb 22, 2022
Merged

Conversation

djds
Copy link
Contributor

@djds djds commented Feb 19, 2022

Proposed changes

  • [style] Update pre-commit hooks
  • [typing] Add typing stubs to test-requirements.txt
  • [build] PEP 517: Add pypa/build to test-requirements.txt
  • [build] Add Makefile
  • [build] Add pyproject.toml
  • [build] Add setup.cfg
  • [build] Remove setup.py
  • [build] Set package version in init.py
  • [ci.github] Autoformat codeql-analysis workflow config
  • [ci.circleci] Autoformat CircleCI config
  • [ci.circleci] PEP-517: Build deterministic wheel
  • [ci.circleci] Add isort check, Python 3.7 tests
  • [ci.circleci] Check version in CircleCI config
  • [ci.circleci] Replace 'echo -e' with printf
  • [ci.circleci] Update slack notification orb 4.7.1 => 4.8.0
  • [ci.circleci] Parallelize tests for Python versions
  • [style] Order imports with isort; autoformat with black
  • [style] update black 20.8b1 => 22.1.0
  • [connector] Lint opencti_connector_helper
  • [ci.github] Lint markdown
  • [doc] Lint requirements.txt
  • [examples] Lint example code
  • [tests] Add trailing newline to test data
  • [style] Lint requirements.txt
  • [style] Remove trailing whitespace

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@djds djds force-pushed the djds/pep-517 branch 6 times, most recently from ae3edb8 to fc7a73d Compare February 20, 2022 23:48
@djds djds force-pushed the djds/pep-517 branch 2 times, most recently from 7daf7fa to faf1ebf Compare February 20, 2022 23:58
@nor3th
Copy link
Contributor

nor3th commented Feb 21, 2022

Hey @djds

Thank you very much for your amazing PR!!! Everything looks good to be, I'll wait for @SamuelHassine if he has any input on your PR before merging it.

Regards

@SamuelHassine
Copy link
Member

Good to me as well, you can merge @nor3th! Thanks a lot @djds for this amazing work!

@nor3th nor3th merged commit 5952627 into OpenCTI-Platform:master Feb 22, 2022
@djds djds deleted the djds/pep-517 branch February 25, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants