Changed P05_CheckForPairSum.py #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s-sanyal thanks for contributing. The sieve of erathostenes program in not Python3 compatible. Please make the necessary changes and modify the PR 😄 |
|
ofcourse...will be doing it just now |
OmkarPathak
requested changes
Oct 3, 2018
There was a problem hiding this comment.
Hi @s-sanyal please also change the function name. Remember that in Python, you use Camel Case for defining class names. You can use sieve_of_eratosthenes() as function name 😄
| # driver program | ||
| if __name__=='__main__': | ||
| n = 30 | ||
| print "Following are the prime numbers smaller", |
There was a problem hiding this comment.
For example, use print() for Python3 compatibility
| # Python program to print all primes smaller than or equal to | ||
| # n using Sieve of Eratosthenes | ||
|
|
||
| def SieveOfEratosthenes(n): |
There was a problem hiding this comment.
Also see that your code is PEP compatible. You don't generally use Camel Case for function names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the code more efficient in terms of Time Complexity as using Quick Sort in Worst Case will take O(n^2), so I have made use of the inbuilt Merge Sort method of Python
sorted()to sort the array in ascending order. The worst case complexity of Merge Sort in O(n*log(n)) which is better the Quick Sort