Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type for token.expires #4338

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

Sander0542
Copy link
Contributor

@Sander0542 Sander0542 commented Feb 3, 2025

Currently, the token.expires property is advertised as an interger in the api schema, but the API returns a ISO string. I updated the schema to match the actual API.

expires: expiry.toISOString()

expires: expiry.toISOString()

expires: expiry.toISOString(),

@nginxproxymanagerci
Copy link

Docker Image for build 1 is available on
DockerHub
as nginxproxymanager/nginx-proxy-manager-dev:pr-4338

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes
Note: this is a different docker image namespace than the official image

@jc21
Copy link
Member

jc21 commented Feb 5, 2025

Hmm right you are. It used to be a UNIX timestamp integer, not sure when that changed but the frontend doesn't really use it anyway.

@jc21 jc21 merged commit e1c84a5 into NginxProxyManager:develop Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants