Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added certbot plugin for Beget DNS service #4148

Merged
merged 7 commits into from
Dec 29, 2024

Conversation

Medan-rfz
Copy link
Contributor

Added support for DNS provider Beget using the sertbot plugin certbot-dns-beget

@jc21
Copy link
Member

jc21 commented Nov 25, 2024

Please test this docker image and let me know if the DNS plugin change works as expected. Thanks

@zagorodnovv
Copy link

zagorodnovv commented Dec 1, 2024

I used the NPM image on 01.12.2024 nginxproxymanager/nginx-proxy-manager-dev:pr-4148

When logging into SSL Certificates - And Let's Encrypt Certificate - Use a DNS Challenge, there is nothing related to Beget in the list

@jc21
Copy link
Member

jc21 commented Dec 2, 2024

It shows up for me:

Screenshot 2024-12-02 at 10 41 55 am

@jc21 jc21 added the requires-verification Waiting for one or more people to confirm the fix label Dec 2, 2024
@zagorodnovv
Copy link

zagorodnovv commented Dec 2, 2024

Greetings again!

You are right, it was a mistake on my part when I said that there is no Beget in the list. I started NPM in another browser and now I see this entry.

Everything worked for me, I want to tell you about the important points:

  1. The website for the Beget API says:

By default, API access is not provided.
To work with the API, you need to set a separate password to access the API and allow API authentication in the control panel (https://beget.com/ru/kb/api/obshhij-princzip-raboty-s-api#sposob-vzaimodeystviya).

That is, first you need to go to your personal account Beget.com enable this feature.

API_Beget
  1. There is a flaw in the Credentials File Content field, it is written like this and it does not work:
# Beget API credentials used by Certbot
beget_plugin_username = username�eget_plugin_password = password
dns_beget

I did so and it worked:

# Beget API credentials used by Certbot
beget_plugin_username = my_username_beget
beget_plugin_password = my_API_password_beget
beget_ssl_2
  1. When trying to create an SSL certificate, I had 2 or 3 unsuccessful attempts, as a result, I set the value of Propagation Seconds to 60
beget_ssl

P.S.

I myself use Nginx Proxy Manager LXC (https://community-scripts.github.io/ProxmoxVE/scripts?id=nginxproxymanager), there is no way to use Beget. How soon can I start using the Beget plugin?

"package_name": "certbot-beget-plugin",
"version": "~=1.0.0.dev8",
"dependencies": "",
"credentials": "# Beget API credentials used by Certbot\nbeget_plugin_username = username\beget_plugin_password = password",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...beget_plugin_username\beg...

should be

...beget_plugin_username\nbeg...

it's missing the n after the slash

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the inattention, I made a correction

@nginxproxymanagerci
Copy link

Docker Image for build 7 is available on
DockerHub
as nginxproxymanager/nginx-proxy-manager-dev:pr-4148

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes
Note: this is a different docker image namespace than the official image

@jc21 jc21 merged commit ec12d8f into NginxProxyManager:develop Dec 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-verification Waiting for one or more people to confirm the fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants