-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add two new headers to proxy.conf #1614
Feature: Add two new headers to proxy.conf #1614
Conversation
Fixes #1609. Adding both X-Forwarded-Host and X-Forwarded-Port, this is vital for some services behind a proxy (used to allow creation of absolute links in html). I've had to include at least the Host version in the past for jenkins and nexus. Been running locally for 24 hours, does not appear to break any of my 15+ services currently running behind NPM would allow people to host those services without the need for advanced configuration
This appears to be failing due to lack of python during the sqlite3 build in the backed.
This appears to be looking for python2 (/usr/bin/python) rather than python3 (/usr/bin/python3), anything changed in that regard in the CI system lately? |
I think this is because node:latest is now based on Debian bullseye (SHA1 hashes for latest and current-bullseye match). Bullseye by default no longer has python 2 installed. So either we |
Wasn't the EOL for Python 2.7 in 2020 already? Would make absolutely no sense to use that going forwards. |
If node-gyp does support python 3 , then we need to fix the bullseye alternatives to allow python 3 to be used for /usr/bin/python so the build scripts will find python in their path.
|
You might have to rebase on the |
This is an automated message from CI: Docker Image for build 3 is available on DockerHub as Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes. |
I have to revert this PR due to #1717. Perhaps there is another way around this. Re-reading the PR comment above, I use jenkins behind NPM and haven't had a problem with it in the past. |
as it breaks some existing services
Fixes #1609. Adding both X-Forwarded-Host and X-Forwarded-Port, this is vital for some services behind a proxy (used to allow creation of absolute links in html). I've had to include at least the Host version in the past for Jenkins and Nexus.
Been running locally for 24 hours, does not appear to break any of my 15+ services currently running behind NPM would allow people to host those problem services without the need for advanced configuration.