Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes dnspod credentials template #1600

Merged
merged 2 commits into from
Jan 2, 2022
Merged

Fixes dnspod credentials template #1600

merged 2 commits into from
Jan 2, 2022

Conversation

chaptergy
Copy link
Collaborator

Fixes #1599

@chaptergy
Copy link
Collaborator Author

CI fails due to node-gyp not being able to download a tarball, so it has nothing to do with the changes in this PR.

@jc21
Copy link
Member

jc21 commented Dec 27, 2021

You might have to rebase on the develop branch again as the python build error fix has been added

@chaptergy chaptergy force-pushed the updates-dnspod-dns-challenge branch from 697cc4b to b78c7e1 Compare December 27, 2021 20:13
@jc21
Copy link
Member

jc21 commented Dec 27, 2021

This is an automated message from CI:

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1600

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@chaptergy chaptergy marked this pull request as draft January 1, 2022 17:04
@chaptergy chaptergy marked this pull request as ready for review January 2, 2022 10:50
@jc21
Copy link
Member

jc21 commented Jan 2, 2022

This is an automated message from CI:

Docker Image for build 5 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1600

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21 jc21 merged commit a082ec0 into develop Jan 2, 2022
@jc21 jc21 deleted the updates-dnspod-dns-challenge branch January 11, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid DNSpod credentials template
2 participants
@chaptergy @jc21