fix: works with npm/yarn/pnpm link #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we use __dirname to find parent root project. But this wont work in a link situation where __dirname will point to the real folder of the plugin. Now we use `process.cwd()` which will work in whatever folder we are inside the project (which is what we want). plus it will be much faster as most of the time `process.cwd()` will already be the app root folder
Contributor
|
obsolete via 96380ea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we use __dirname to find parent root project. But this wont work in a link situation where __dirname will point to the real folder of the plugin. Now we use
process.cwd()which will work in whatever folder we are inside the project (which is what we want). plus it will be much faster as most of the timeprocess.cwd()will already be the app root folder