This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: update the css loader in order to fix a bug with leading dashes in css classes #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
test ng-apps |
DimitarTachev
force-pushed
the
tachev/fix-css-encoding
branch
from
cd429da to
3fe8c9e
Compare
|
test ng-apps |
|
test cli-templates cli-smoke tns_core_modules_unit_tests cuteness uitests modal_navigation animations groceries sdk_ng sdk_js renderer router JavaScriptApp TypeScriptApp AngularApp templates |
|
test cli-templates cli-smoke ng-apps package_version#latest |
|
Version 1.0.0 removes |
vchimev
approved these changes
Apr 3, 2019
|
run ci |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
We were using an old version of the css loader containing the following issue: webpack-contrib/css-loader#578 and causing the below-mentioned issue in NativeScript apps.
What is the new behavior?
The below-mentioned issue is fixed in the latest version of the css-loader.
Related to: #846