fix(debugging): Do not close data socket prematurely #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple dispatch_io operations are usually running
simultaneously. When recreating the inspector listening
socket after an "AttachRequest" notification from {N} CLI,
the following crash happened in a dispather worker thread:
`BUG IN CLIENT OF LIBDISPATCH: Unexpected EV_VANISHED (do not destroy random mach ports or file descriptors)`
The reason turned out that we always have at least 2 pending
current operations. One is reading the next message,
and the other one -- the cleanup handler from `dispatch_io_create`.
rosen-vladimirov
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple dispatch_io operations are usually running
simultaneously. When recreating the inspector listening
socket after an "AttachRequest" notification from {N} CLI,
the following crash happened in a dispather worker thread:
BUG IN CLIENT OF LIBDISPATCH: Unexpected EV_VANISHED (do not destroy random mach ports or file descriptors)The reason turned out to be that we always have at least 2 pending
current operations. One is reading the next message,
and the other one -- the cleanup handler from
dispatch_io_create.PR Checklist
refs #1254