Skip to content

fix(runtime): Correctly retrieve discarded exceptions flag #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2019
Merged

fix(runtime): Correctly retrieve discarded exceptions flag #1241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/NativeScript/JSErrors.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ void reportErrorIfAny(JSC::ExecState* execState, JSC::CatchScope& scope) {
|| globalObject->isUIApplicationMainAtTopOfCallstack();

if (treatExceptionsAsUncaught) {
id discardExceptionsValue = [[TNSRuntime current] appPackageJson][@"discardUncaughtJsExceptions"];
id discardExceptionsValue = [[TNSRuntime runtimeForVM:&execState->vm()] appPackageJson][@"discardUncaughtJsExceptions"];
bool discardExceptions = [discardExceptionsValue boolValue];
scope.clearException();
if (discardExceptions) {
Expand Down Expand Up @@ -181,8 +181,8 @@ void reportFatalErrorBeforeShutdown(ExecState* execState, Exception* exception,
CFRunLoopRunInMode((CFStringRef)TNSInspectorRunLoopMode, 0.1, false);
}
}
id discardExceptionsValue = [[TNSRuntime current] appPackageJson][@"discardUncaughtJsExceptions"];

id discardExceptionsValue = [[TNSRuntime runtimeForVM:&execState->vm()] appPackageJson][@"discardUncaughtJsExceptions"];
bool discardExceptions = [discardExceptionsValue boolValue];
if (!discardExceptions) {
String message = exception->value().toString(globalObject->globalExec())->value(globalObject->globalExec());
Expand Down