fix(inspector): JS Error due to missing methods from InspectorFrontendHost #1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darind
approved these changes
Dec 13, 2019
* A lot of commands are not supported by NativeScript. We'd better
keep the previous behaviour of simply reporting without stopping
on such errors.
* Revive the commented `activateDomain` calls. Since they are no
longer shown in the UI its better to keep them, so that the frontend
starts working if they become implemented in the future.
* Match {N} CLI's debugger proxy port. This way it will be possible
to use Safari for debugging the frontend without relying on the
proxy in `src/debugging` of iOS Runtime's repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
refs #1238