fix(runtime): Expose base class missing properties in inheritors #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbektchiev
force-pushed
the
bektchiev/fix-ui-bar-item-properties
branch
from
af52a16 to
a5f6a1d
Compare
Fix issue with missing `imageInsets`, `landscapeImagePhone`, `title` properties of UITabBarItem. These properties are declared in `UIBarItem` but it actually doesn't implement them. Some of its successors like `UITabBarItem` however do, and we need to expose them there. This regression has been introduced with #1086.
mbektchiev
force-pushed
the
bektchiev/fix-ui-bar-item-properties
branch
from
a5f6a1d to
e34f49e
Compare
tdermendjiev
approved these changes
Mar 12, 2019
SvetoslavTsenov
approved these changes
Mar 12, 2019
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with missing
imageInsets,landscapeImagePhone,titleproperties of UITabBarItem.These properties are declared in
UIBarItembut it actually doesn't implement them. Some of itssuccessors like
UITabBarItemhowever do, and we need to expose them there.This regression has been introduced with #1086 (which addressed #1084, #1085)
PR Checklist