Skip to content

two changes:1,added error handling to BannerAd; 2. Allow error to bub… #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2023
Merged

two changes:1,added error handling to BannerAd; 2. Allow error to bub… #102

merged 1 commit into from
Jun 20, 2023

Conversation

jazdance
Copy link
Contributor

@jazdance jazdance commented Jun 19, 2023 •
edited
Loading

two changes:

  1. Added error handling to BannerAd which is causing crashes from time to time - compared with other types of ads;
  2. Allow error to bubble up to JS/TS level, so RN app can handle these errors.

@jazdance
two changes:1,added error handling to BannerAd; 2. Allow error to bub…
c52cec4 
…ble up to JS/TS level, so RN app can handle these errors.
@aleccolville-nzme aleccolville-nzme merged commit b2b7276 into master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manojalwisnz manojalwisnz Awaiting requested review from manojalwisnz

@mharrison-nzme mharrison-nzme Awaiting requested review from mharrison-nzme

@taylornzme taylornzme Awaiting requested review from taylornzme

@aleccolville-nzme aleccolville-nzme Awaiting requested review from aleccolville-nzme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jazdance @aleccolville-nzme