Merged
Conversation
added 8 commits
February 9, 2020 12:36
tebueno
reviewed
Feb 10, 2020
| return namestring; | ||
| //console.log(namestring); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Convert to ES6 syntax ie: .map(x => {}).
tebueno
reviewed
Feb 10, 2020
|
|
||
| function firstandlastname (x){ | ||
| const space = ' ' | ||
| const namestring = x.first + space + x.last; |
Collaborator
There was a problem hiding this comment.
Use string literal syntax please
tebueno
reviewed
Feb 10, 2020
| function oldesttoyoungest(a,b){ | ||
| return a.year-b.year; | ||
| } | ||
|
|
tebueno
reviewed
Feb 10, 2020
|
|
||
| function livetogether(totalyears, x){ | ||
| return totalyears+ (x.passed - x.year); | ||
| } |
Collaborator
There was a problem hiding this comment.
Good job. Please convert to ES6
Collaborator
|
@Laryl14 Good job!! Please address my comments before I can merge. Also, clean up code using camel case only. |
tebueno
requested changes
Feb 11, 2020
Collaborator
tebueno
left a comment
tebueno
left a comment
There was a problem hiding this comment.
Fix camel case + other comments
tebueno
approved these changes
Feb 18, 2020
Collaborator
tebueno
left a comment
tebueno
left a comment
There was a problem hiding this comment.
Nice job cleaning up the code. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved all problems except for wesbos#6