Use If-modified-since headers to avoid X-Rate-Limit decrease #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
I think this is better :)
Contributor
There was a problem hiding this comment.
Such method not exist in Response class.
Contributor
Author
There was a problem hiding this comment.
I just added it :) oops
Contributor
|
Why the tests actually do calls to the github api?? |
Contributor
There was a problem hiding this comment.
This will fail if cache was not found and response was not modified (i.e. some GC cleaned temp folder)
stloyd
added a commit
that referenced
this pull request
Dec 21, 2012
Use If-modified-since headers to avoid X-Rate-Limit decrease
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.