Add per_page and page parameters to Member->all() #1140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows developers to actually get all() members.
GrahamCampbell
suggested changes
Jun 7, 2024
Contributor
GrahamCampbell
left a comment
GrahamCampbell
left a comment
There was a problem hiding this comment.
This is incorrect. The result pager is for this. https://github.com/KnpLabs/php-github-api/blob/master/doc/result_pager.md
Contributor
Author
|
Ah thank you, my mistake. I missed this in the docs. Will close PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows developers to actually get all() members.