Handle case of GitHub returning 204 No Content in some scenarios #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h breaks ResultPager because no array is returned (it's an empty string) - issue ResultPager::get() can return string KnpLabs#1091
acrobat
requested changes
Mar 24, 2024
Collaborator
acrobat
left a comment
acrobat
left a comment
There was a problem hiding this comment.
@tomcorbett thanks for the PR! Can you also add a test for this to avoid any regressions in the future? Thanks!
See: https://github.com/KnpLabs/php-github-api/blob/master/test/Github/Tests/ResultPagerTest.php
Contributor
Author
|
@acrobat - of course, apologies, I haven't written a unit test in probably 10 years... so I apologize if this is wrong |
acrobat
approved these changes
Mar 24, 2024
Collaborator
acrobat
left a comment
acrobat
left a comment
There was a problem hiding this comment.
No worries @tomcorbett, test looks good 👌
Collaborator
|
Thanks @tomcorbett! And congrats on your first contribution! 🎉 |
Contributor
Author
|
Awesome, thank you @acrobat !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResultPager breaks because no array is returned (it's an empty string) - issue ResultPager::get() can return string #1091