Unable to retrieve pull request diff

[morozov]

The following code snippet is supposed to produce the pull reques diff. It used to work a while ago but now it doesnt.

$client = new Github\Client();
$client->authenticate(
    'put-your-token-here',
    null,
    Github\Client::AUTH_URL_TOKEN
);

/** @var Github\Api\PullRequest $api */
$api = $client->api('pull_request');
$client->setHeaders(array(
    sprintf(
        'Accept: application/vnd.github.%s.diff',
        $client->getOption('api_version')
    )
));

$diff = $api->show('KnpLabs', 'php-github-api', '92');

echo gettype($diff);
// expected: string
// actual: array

The point is that here default Accept header is appepended with custom but not overridden, thus both of them are sent.

Default User-Agent and Accept headers should be sent only if other values are not specified.

[cursedcoder]

The library provides you github api v3, you can check actual documentation here http://developer.github.com/v3/pulls/#get-a-single-pull-request

I just checked code snippet you have provided and the output is exactly the same as mentioned in v3 docs.

Can't really help on that because github no longer supports older versions AFAIK.
But of course you can try your code snippet with older versions of library.

[morozov]

GitHub API v3 also supports custom media types for pull requests.

Please try running the following:

curl https://api.github.com/repos/KnpLabs/php-github-api/pulls/92 \
  -H "Accept: application/vnd.github.v3.diff"

[cursedcoder]

@morozov you have to specify header key instead of plain text:

$client->setHeaders(array(
    'Accept' => sprintf('application/vnd.github.%s.diff', $client->getOption('api_version'))
));

[morozov]

👍 Thanks!