ENH: Improve DataImporter #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phcerdan
force-pushed
the
improve_dataimporter
branch
5 times, most recently
from
0fdd66f to
324964c
Compare
phcerdan
force-pushed
the
improve_dataimporter
branch
4 times, most recently
from
63a0f75 to
9980ad8
Compare
|
Closes #54 |
phcerdan
force-pushed
the
improve_dataimporter
branch
3 times, most recently
from
77a9aab to
453ecae
Compare
Also add unit-test to ctest.
Add importLabelMap Add importSegmentation: image (.seg) or vtm (.seg.vtm) Add tests Remove csv mode TODO: - GUI, remove unused.
Remove csv mode
Fortify logic handling segmendId instead of segmentIndex. Better error/warning messages.
Remove its trivial usage from DataImporter
TODO: - Functions to display segments should be moved outside logic into widget - Table might contain more information that just the name. - Think about re-implementing a tab for a csv file.
phcerdan
force-pushed
the
improve_dataimporter
branch
from
453ecae to
fe4bbae
Compare
TODO: - Control Display (selected in table or selected in column) -[x] Enable CSV
phcerdan
force-pushed
the
improve_dataimporter
branch
from
e27ef83 to
5fcf7aa
Compare
jcfr
reviewed
Sep 11, 2018
| return True | ||
|
|
||
| def filePathsFromCSVFile(self, csvFileName): | ||
| """ |
There was a problem hiding this comment.
May be you could also use the Slicer reader for loading table file (aka csv)?
There was a problem hiding this comment.
Not resolved... yet
allemangD
added a commit
that referenced
this pull request
Oct 29, 2021
New commits:
$ git shortlog 602046b..7414e09
David Allemang (3):
WIP: Fix VTK_USE_QVTKOPENGLWIDGET condition
WIP: VTK_OVERRIDE -> override
Merge pull request #56 from NIRALUser/vtk9
Jared Vicory (1):
BUG: Use correct filter for reducing number of vectors
Jean-Christophe Fillion-Robin (6):
Merge pull request #50 from slicersalt/slicersalt-2019-11-20-bd4bdcf
ENH: Support use of extension wizard simplify setting of EXTENSION_* vars
Merge pull request #51 from jcfr/support-extension-wizard-use
COMP: Generate (Extension)Config.cmake
Merge pull request #52 from jcfr/generate-config-file
Merge pull request #54 from NIRALUser/53-fix-qt5-build-error
Sam Horvath (1):
COMP: Qt 5.15 needs QPainterPath include with QPainter
Ye Han (5):
ENH: Allow import .xml file to visualize S-Rep
ENH: Visualize spokes and assign point data for coloring
ENH: Load customized colormap when reading SReps
ENH: Allow SPV to Load SReps from CLI
ENH: Allow reading s-rep from csv files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows reading LabelMaps, Segmentations, and Models.
Things to improve / todo:
not great.